Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] delivery_gls_asm: Migration to 18.0 #4090

Open
wants to merge 48 commits into
base: 18.0
Choose a base branch
from

Conversation

arantxa-s73
Copy link
Contributor

@arantxa-s73 arantxa-s73 commented Mar 21, 2025

chienandalu and others added 30 commits March 21, 2025 11:48
[UPD] Update delivery_gls_asm.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-12.0/l10n-spain-12.0-delivery_gls_asm
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-delivery_gls_asm/

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-12.0/l10n-spain-12.0-delivery_gls_asm
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-delivery_gls_asm/
Currently translated at 68.4% (93 of 136 strings)

Translation: l10n-spain-12.0/l10n-spain-12.0-delivery_gls_asm
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-delivery_gls_asm/es/
Non implemented methods should raise informative exceptions if used

[UPD] Update delivery_gls_asm.pot

delivery_gls_asm 12.0.1.0.1

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-12.0/l10n-spain-12.0-delivery_gls_asm
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-delivery_gls_asm/
delivery_gls_asm 12.0.1.0.2
The `cliente` key corresponds to the company not to the customer, wich
is `nombre_dst`

delivery_gls_asm 12.0.1.0.3
Alhough it will raise another exception, at least it will show the
proper message and not a traceback.
Ensure that the values sent to the xml soap request are properly
escaped. A partner name like "Johnson & Johnson" would fail otherwise.
[UPD] Update delivery_gls_asm.pot

[UPD] README.rst
Currently translated at 98.5% (135 of 137 strings)

Translation: l10n-spain-13.0/l10n-spain-13.0-delivery_gls_asm
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-13-0/l10n-spain-13-0-delivery_gls_asm/es/
Currently translated at 5.2% (7 of 134 strings)

Translation: l10n-spain-13.0/l10n-spain-13.0-delivery_gls_asm
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-13-0/l10n-spain-13-0-delivery_gls_asm/ca/
Add field for GLS specific states, so the customer can have the same tracking and grouping
on Odoo as they have on the GLS interface
`res_country.phone_code` is an Integer field, thus it should not be
scaped.

TT33879
GLS ASM API has a limit of 15 characters for its reference so we should
avoid sequences longer than that if we want to avoid collisions.

TT33272

[UPD] Update delivery_gls_asm.pot

delivery_gls_asm 14.0.1.1.1

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-14.0/l10n-spain-14.0-delivery_gls_asm
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-14-0/l10n-spain-14-0-delivery_gls_asm/
Add error codes meaning and rearrange master data in an independent
file.

TT34458
When we deliver to some destinations, the mobile phone and the email
address turn into required fields. We try to fallback to the ones
informed in the commercial entity data.

TT34458

delivery_gls_asm 14.0.1.1.2

[UPD] Update delivery_gls_asm.pot

delivery_gls_asm 14.0.1.2.0

[UPD] Update delivery_gls_asm.pot

delivery_gls_asm 14.0.1.3.0
[UPD] Update delivery_gls_asm.pot
- If the manifest only comes with 1 delivery it is in form of a singular dict instead of a list of dicts and this causes issues when iterating in the XML

delivery_gls_asm 14.0.1.4.1
[UPD] README.rst

delivery_gls_asm 14.0.1.4.2
victoralmau and others added 16 commits March 21, 2025 11:48
Currently translated at 77.0% (144 of 187 strings)

Translation: l10n-spain-15.0/l10n-spain-15.0-delivery_gls_asm
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-15-0/l10n-spain-15-0-delivery_gls_asm/es/
- Fix tests to declare packages explicitly
- Fix wrong keyword literals on errors

TT45144
Currently translated at 100.0% (189 of 189 strings)

Translation: l10n-spain-15.0/l10n-spain-15.0-delivery_gls_asm
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-15-0/l10n-spain-15-0-delivery_gls_asm/es/
New shipping times and renaming of some of them by GLS

TT48760
Check the actual value that is being sent to GLS, since it doesn't make sense to error for 15 characters when the value you would send doesn't actually exceed that limit
My use case is that we have some clients that deliver a whole stock.picking.batch instead of stock.picking individually,
therefore the reference we use is the batch's name (overwritten through _prepare_gls_asm_shipping).
This started erroring when the picking reference reached 16 characters while the batch reference is still only 10
@arantxa-s73 arantxa-s73 force-pushed the 18.0-mig-delivery_gls_asm branch 2 times, most recently from f94cecf to 01a20d4 Compare March 27, 2025 09:04
@ioans73
Copy link
Member

ioans73 commented Mar 27, 2025

@Tisho99 @ValentinVinagre @HaraldPanten @luis-ron alguien sabe por casualidad que puede estar provocando el error actual de lo tests? Devuelve el código -135, pero parece que no está documentado por ninguna parte

odoo.exceptions.UserError: GLS returned an error trying to record the shipping for ODOO-1743066432.
Error:
-135

@pedrobaeza los tests que desactivaste en la versión 17.0, puede que fuera por lo mismo? bb967bf

@ValentinVinagre
Copy link
Contributor

@Tisho99 @ValentinVinagre @HaraldPanten @luis-ron alguien sabe por casualidad que puede estar provocando el error actual de lo tests? Devuelve el código -135, pero parece que no está documentado por ninguna parte

odoo.exceptions.UserError: GLS returned an error trying to record the shipping for ODOO-1743066432.
Error:
-135

@pedrobaeza los tests que desactivaste en la versión 17.0, puede que fuera por lo mismo? bb967bf

Por lo que veo en los tests que indicas en el commit, se desactivó por el mismo error. En el PR antes de ese commit daba el mismo fallo, te pongo la traza de los tests antes de ese commit.
https://github.com/OCA/l10n-spain/actions/runs/13475221437/job/37653541661#step:8:676

Es bastante posible que sea por la API según como indicaba Pedro. Entiendo que lo mejor sería hablar con gls a ver si han cambiado algo sobre la conexión de test o si no realizar un mockup.

@pedrobaeza
Copy link
Member

Sí, el problema creo que es que no "procesan" a tiempo tu petición, y cuando ya pides con el número que ellos mismos te han dado, aún no está presente. Hay que dejar pasar un tiempo, pero claro, no es cuestión de poner "sleeps" y cosas así, así que desactívalos si no.

@ioans73
Copy link
Member

ioans73 commented Mar 27, 2025

Vale, vamos a desactivarlo de momento y en cualquier caso, más adelante podemos ver una solución más correcta.

Gracias!

@arantxa-s73 arantxa-s73 force-pushed the 18.0-mig-delivery_gls_asm branch from 01a20d4 to 5d67023 Compare March 27, 2025 14:00
@pedrobaeza
Copy link
Member

/ocabot migration delivery_gls_asm

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Mar 27, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 27, 2025
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.